Beefy Boxes and Bandwidth Generously Provided by pair Networks
Problems? Is your data what you think it is?

Comment on

( #3333=superdoc: print w/replies, xml ) Need Help??
The most weird error messages i get from Perl::Critic are those:
Regular expression without '/m' flag Regular expression without '/x' flag
They look very funny when they both refer to the line like this:
next if /^;/; #skip comments
I think you can set a length limit for the regular expressions to receive a warning about /x flag. Maybe, regexes shorter than e.g. 7 characters do not need /x flag? Or even better—remove warnings for regexes containing less than 5 metacharacters, e.g. /(foo|bar)/? The regexes containing only ONE interpolated variable (like the one mentioned below) must not cause them, too.

The warning about /m simply looks weird for me though I can understand why do you use it. But it must not appear to the lines like

$string =~ /$re/;

The next bug: the line
local $" = '|';
causes two warnings:
Variable declared as 'local' Magic punctuation variable used

while it must cause only the second warning! To use or not to use the punctuation variables is some kind of personal style, but not local'izing them is a severe error!

A little tip about the web-interface: You could add a possibility for the user to re-sort your warnings list by severity or by categories. The list would also look much better if it was represented by a table rather than by a simple linklist :)

Despite all my remarks you have done a great work ad i hope that my comments will help you to improve it :)

Sorry for my bad English—it's not my native language :)

In reply to Re: Request for Perl::Critic Testimonials (some weirdnesses of the module) by Ieronim
in thread Request for Perl::Critic Testimonials by jthalhammer

Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":

  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?

    What's my password?
    Create A New User
    and all is quiet...

    How do I use this? | Other CB clients
    Other Users?
    Others perusing the Monastery: (5)
    As of 2018-03-21 19:03 GMT
    Find Nodes?
      Voting Booth?
      When I think of a mole I think of:

      Results (270 votes). Check out past polls.