Beefy Boxes and Bandwidth Generously Provided by pair Networks Joe
Problems? Is your data what you think it is?
 
PerlMonks  

Comment on

( #3333=superdoc: print w/ replies, xml ) Need Help??
You decided that my English is so poor that i can't read the docs of Perl::Critic and understand why these warnings appeared? ;)

Your comment contains many errors :( Yes, if i modify my code according to your recommendations, Perl::Critic will stop complainingóbut my code will stop working :)

Your recommendation to use

next if /^;/xms;
is very weird. The using of /s and /m switches together causes a very unexpected interpretation of the RegEx:

perlretut says:
both s and m modifiers (//sm): Treat string as a single long line, but detect multiple lines. '.' matches any character, even "\n". ^ and $, however, are able to match at the start or end of any line within the string.

Do you still think that it's a good idea to add /ms to the end of each regex?

Don't use local variables, use my. Don't the special variables like $", use the English module.
use English qw( -no_match_vars ); my $LIST_SEPERATOR = q{|};

  1. The Perl built-in variables lose their magic capabilities when declared as my. Didn't you know?
  2. There is no $LIST_SEPERATOR. Use $LIST_SEPARATOR instead.
  3. If you don't believe me, try the following code:
    #!/usr/bin/perl use warnings; use strict; use English qw( -no_match_vars ); { local $LIST_SEPARATOR = q{!}; my @list = qw/this is my list/; print "@list\n"; }
    and then try to replace 'local' with 'my'.
    BTW, Perl::Critic does not complain about local'ising in the code above ;)

      s;;Just-me-not-h-Ni-m-P-Ni-lm-I-ar-O-Ni;;tr?IerONim-?HAcker ?d;print

In reply to Re^3: Request for Perl::Critic Testimonials (some weirdnesses of the module) by Ieronim
in thread Request for Perl::Critic Testimonials by jthalhammer

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • Outside of code tags, you may need to use entities for some characters:
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?
    Username:
    Password:

    What's my password?
    Create A New User
    Chatterbox?
    and the web crawler heard nothing...

    How do I use this? | Other CB clients
    Other Users?
    Others surveying the Monastery: (5)
    As of 2014-04-19 08:44 GMT
    Sections?
    Information?
    Find Nodes?
    Leftovers?
      Voting Booth?

      April first is:







      Results (478 votes), past polls