Comment on

After a quick skim, it looks pretty good to me, one comment on the SYNOPSIS though.

sub get_widget {
    my ($self, $params) = @_;
    
    unless (my_validation_function($params->{product_number})) {
        REST_error('404', 'Invalid product_number');
    }
    
    my $widget = $widgets[$params->{product_number}];

    if (REST_media_type eq 'text/plain') {
        return $self->plain_output($widget);
    }
    
    return $self->fancy_output($widget);
}
[download]

Shouldn't the calls to REST_error and REST_media_type be method calls, and not function calls?

Also, I would suggest wrapping $params in an object as well. You might not need it now, but when you do, it will be a royal pain to go back and change all the legacy code. (give Class::Param a look, it seems to have lots of functionality available if/when you need it)

-stvn

In reply to Re: RFC: CGI::Application::Plugin::REST by stvn
in thread RFC: CGI::Application::Plugin::REST by jaldhar

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

Outside of code tags, you may need to use entities for some characters:

	For:		Use:
	&		`&`
	<		`<`
	>		`>`
	[		`[`
	]		`]`

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.


Your skill will accomplish what the force of many cannot
	PerlMonks

Comment on

The best material for plates (tableware) is: