Leaving the whole thing about RCS keywords (my grandfather used RCS, I use subversion ;) and specifc POD sections (maybe I don't want to name them the way TheDamian does) aside, I am surpised at a couple of things in the output:

• Magic punctuation variable used at line ...

The magic punctuatinon it is talking about is $@ without which I could not really catch exceptions. I think that is a little severe.

• Useless interpolation of literal string at line ...

I don't even get that one because the line in question is basically something like this:

confess 'Some error happened because ' . $obj->foo . ' blew up';
[download]

I would have to say that this string was far from useless.
• Subroutine does not end with "return" at line ...

Now, I can understand this for large subroutines, but the sub in queston was basically this:

sub mumble_path { join ", " => split '/' => (shift)->get_path }
[download]

I would argue that adding return to something like that would be just adding noise.

Of course I know you are supposed to be able to customize Perl::Critic to your own tastes, but I wonder if the default settings are maybe not too severe? My first thoughts when I saw all the output was similar to BrowserUK, I felt like I was looking at some overpriced Java middleware exception stack trace.

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.