FYI, a starting point for an appropriate ~/.perlcriticrc for you (based on the above) might look like:
[-InputOutput::ProhibitTwoArgOpen] #if applicable to opendir
I wouldn't disparage the tool because it recommends things you don't agree with. I think even TheDamian suggests that not everyone will agree with every "Best Practice", as any thread concerning PBP here will clearly show. However, enough can not be said for something that helps a team of developers write all code in a consistent manner, a manner that tends toward readability, maintainability, and as few bugs due to misunderstandings as possible.
For posterity, my ~/.perlcriticrc file looks like this:
allow = if
severity = 1
Keep in mind that Perl::Critic is highly configurable, and will only alert you to "issues" at its current reporting level - which is quite low (when using the command line tool without any options).
s**lil*; $*=join'',sort split q**; s;.*;grr; &&s+(.(.)).+$2$1+; $; =
qq-$_-;s,.*,ahc,;$,.=chop for split q,,,reverse;print for($,,$;,$*,$/)
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
Outside of code tags, you may need to use entities for some characters:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
| & || & |
| < || < |
| > || > |
| [ || [ |
| ] || ] ||