Beefy Boxes and Bandwidth Generously Provided by pair Networks
P is for Practical
 
PerlMonks  

Comment on

( #3333=superdoc: print w/ replies, xml ) Need Help??
oko1,
Recently, I was thinking about that example in the docs where they demonstrate a method for inserting commas into a numerical string.

You mean the one from perlfaq5?

but that thing is just clumsy and awful and obfuscated for any Perl beginner. So, just for my own entertainment, I decided to see how I'd do it "for real" - i.e., in the best way possible rather than by this contrived method.

I agree that many of the solutions in the FAQ are written more as a cook book rather than as a tutorial. On the other hand, do you honestly feel that your solutions are any better if your target audience is a perl beginner?

If that is your target audience, I would have gone with something a bit more verbose.

  • Return undef if input is not numeric - perhaps using Scalar::Util's looks_like_number()
  • Return input in tact if it shouldn't be commified (Inf, NaN, already commified, etc) - perhaps using a different sub
  • Perform commification in step-by-step atomic units of work

Since it seems your intended goal was to educate beginners, each step should be preceded by the appropriate amount of comments. It may not be obvious what a regex is doing so you could recommend YAPE::Regex::Explain. They may not have considered edge cases, so rather than incorporate them into a single step that is doing something else - break it out on its own statement.

Cheers - L~R


In reply to Re: Commifying sensibly by Limbic~Region
in thread Commifying sensibly by oko1

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • Outside of code tags, you may need to use entities for some characters:
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?
    Username:
    Password:

    What's my password?
    Create A New User
    Chatterbox?
    and the web crawler heard nothing...

    How do I use this? | Other CB clients
    Other Users?
    Others drinking their drinks and smoking their pipes about the Monastery: (13)
    As of 2014-07-29 18:32 GMT
    Sections?
    Information?
    Find Nodes?
    Leftovers?
      Voting Booth?

      My favorite superfluous repetitious redundant duplicative phrase is:









      Results (226 votes), past polls