In a few spots, you apply "exists" to test an array element. exists() is only meant for testing hash entries, and for me, this generates a compile-time error. You should replace
( exists $ARGV[0] )
with plain old
( $ARGV[0] )
Also, personally I'd take
Win32::NetAdmin::GetUsers ... or die
unless exists $ARGV[0];
if ( exists $ARGV[0] ) {
... }
and turn it into an unless-else:
unless ($ARGV[0]) { Win32::NetAdmin::GetUsers ... }
else { ... }
Style issues aside, as a Linux-user adjusting to Win32, these tools you've posted are good things to have; thanks for posting them.
-- Frag.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|