In addition to the earlier comments, I'd suggest changing (as an example)
$count_G = ( $seq =~ tr/G//);
$ratio_G = ($count_G/$len);
# print "\n$ratio_G\n";
$ratio_G = Calculate( 'G' );
Writing the sub Calculate
is left as an exercise to the reader. The advantages are you
- get rid of all of the temporary $count_* variables
- remove duplicated code
- make future changes (e.g. you want percentage rather than ratio) more centralized
- make the intentions of your code much clearer
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
| & || & |
| < || < |
| > || > |
| [ || [ |
| ] || ] ||