Beefy Boxes and Bandwidth Generously Provided by pair Networks
"be consistent"

Comment on

( #3333=superdoc: print w/ replies, xml ) Need Help??
Yes, using a regular expression is "much more efficient", but yours is in some cases, as you point out, incorrect. And using Net::IP::Match::Regexp you can still do more than sixty seven thousand comparisons per second (on my old and rusty laptop, anyway) if the regexp is initialized once only. So what do you want:
  • Superfast and possibly incorrect, or
  • Fast and correct?
$ cat use strict; use warnings; use Net::IP::Match::Regexp qw( create_iprange_regexp match_ip ); use Benchmark qw / cmpthese /; my $regexp_init_once = create_iprange_regexp( qw( ) + ); sub netip { my $regexp = create_iprange_regexp( qw( + ) ); return ( match_ip( $_[0], $regexp ) ); } sub netip_init_once { return match_ip( $_[0], $regexp_init_once ); } sub regexp { return $_[0] =~ /^(10\.\d+|172\.(1[6-9]|2\d|3[0-1])|192\.168)(\.\d+) +{2}$/; } cmpthese( -1, { 'netip' => sub { netip('') }, 'netip_init_once' => sub { netip_init_once('') }, 'regexp' => sub { regexp('') }, } ); __END__ $ perl Rate netip netip_init_once reg +exp netip 2438/s -- -96% -1 +00% netip_init_once 67622/s 2674% -- - +95% regexp 1390157/s 56918% 1956% + --
No matter how great and destructive your problems may seem now, remember, you've probably only seen the tip of them. [1]

In reply to Re^3: Regexp: Private IP Addresses by andreas1234567
in thread Regexp: Private IP Addresses by Anonymous Monk

Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":

  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?

    What's my password?
    Create A New User
    and the web crawler heard nothing...

    How do I use this? | Other CB clients
    Other Users?
    Others chilling in the Monastery: (4)
    As of 2015-11-26 00:49 GMT
    Find Nodes?
      Voting Booth?

      What would be the most significant thing to happen if a rope (or wire) tied the Earth and the Moon together?

      Results (695 votes), past polls