I wouldn't inherit from Exporter at all, so I would get rid of @ISA=qw(Exporter). Exporter can export its own import() function into your module since v5.57 == Perl 5.8.3 (released 2004-01-14), so there is no need to inherit from Exporter any more. I would not use require, because it requires more typing than use and it is processed at runtime, not at compile time. use Exporter 'import'; is all you need to use Exporter's features from your module. Fall back to ...
use vars qw(@ISA @EXPORT);
@EXPORT=qw( ... );
... only if you need to support really old Perl versions.
Note that there are several Exporter replacements, Sub::Exporter has some very interesting features, but it can export "only" subs, no variables.
Regarding style, I prefer the following: pragmas first, followed by core and CPAN modules, followed by my own modules (mostly application specific). So, a typical module would look like this:
use parent 'MyApp::BaseClass'; # only for OOP classes
use Carp qw( croak ); # only when needed
use DBI; # only when needed
use CGI; # only when needed
our @SVNID=q$Id$; # SVN expands this li
our $VERSION=sprintf('%d',q$Revision$=~/(\d+)/); # SVN expands this li
our @EXPORT=qw( ... ); # not for OOP classes, only when needed
our @EXPORT_OK=qw( ... ); # not for OOP classes, only when needed
our %EXPORT_TAGS=( ... ); # not for OOP classes, only when needed
# more globals, if required
# subs here
Today I will gladly share my knowledge and experience, for there are no sweeter words than "I told you so". ;-)
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
Outside of code tags, you may need to use entities for some characters:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
| & || & |
| < || < |
| > || > |
| [ || [ |
| ] || ] ||