Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl-Sensitive Sunglasses
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??
What makes the script: read zip length of the desired piece and
comes from the cycle of reading early in order to save time
P.S. : Everything happens on the productive
$ Showrev
Release: 5.10
Kernel architecture: sun4u
Application architecture: sparc
Hardware provider: Sun_Microsystems
Kernel version: SunOS 5.10 Generic_142900-09

put additional perl modules I can not (like Archive:: Zip, IO:: Compress:: Zip)
There is code in perl, which is ideally passes through perlclitic
on Brutal (report all violation), but when the perl pipe_quest.pl
unable to close: unzip-c test.zip utp.live.stp.published.messages.txt at pipe_quest.pl line 29
creates the file you want, but an error, how to handle this error correctly, that it was not?
if you close $ FH; do not handle, the code does not pass on perlcritic
Yes, and this may cause a memory leak if the file is large (> 10Gb) and close the pipe still need to be, controlling this leakage.
#!/usr/bin/perl ###################################################################### +######## # $URL: http://mishin.narod.ru $ # $Date: 2011-02-17 20:53:20 +0300 (Mon, 14 Feb 2011) $ # $Author: mishin nikolay $ # $Revision: 1.02 $ # $Source: pipe_quest.pl $ # $Description: script read data from zip file $ ###################################################################### +######## use 5.006; use strict; use warnings; use English qw(-no_match_vars); use Carp; our $VERSION = '0.01'; use Readonly; Readonly my $STRING_NUMBER2EXIT => 1000; my $EMPTY = q{}; my $ret = $EMPTY; my $file_src = 'test.zip'; my $out_file = 'out.xml'; my $file = get_name_from_zip($file_src); open my $FH, q{-|}, "unzip -p $file_src $file" or croak "bah unzip -p $file_src $file"; $ret = search_trade_by_index( $FH, $out_file, $STRING_NUMBER2EXIT ); close $FH or croak "unable to close: unzip -p $file_src $file $ERRNO"; + sub search_trade_by_index { my ( $fh, $xml_filename, $quit_str ) = @_; my @xml_out = (); my $xml_out = $EMPTY; LINE: while ( my $line = <$fh> ) { push @xml_out, $line; if ( $INPUT_LINE_NUMBER eq $quit_str ) { $xml_out = join $EMPTY, @xml_out; $ret = file_write( $xml_filename, $xml_out ); last LINE; } } return 1; } sub get_name_from_zip { my ($loc_file_src) = @_; my ( $ca, $cb, $cc, $loc_file ); my @result = readpipe "unzip -l $loc_file_src"; foreach (@result) { if (/txt$/xsm) { ( $ca, $cb, $cc, $loc_file ) = split; } } return $loc_file; } sub file_write { my ( $wfile, $message ) = @_; open my $fh, q{>}, "$wfile" or croak "unable to open:$wfile $ERRNO +"; $ret = print {$fh} $message; close $fh or croak "unable to close: $wfile $ERRNO"; return 1; }
with best regards, Mishin Nikolay, web-programmer

In reply to how to properly handle the closing of pipe? read from the pipe unzip-c and get out before by mishin

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others rifling through the Monastery: (4)
As of 2024-04-23 15:17 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found