Beefy Boxes and Bandwidth Generously Provided by pair Networks
Problems? Is your data what you think it is?
 
PerlMonks  

Comment on

( #3333=superdoc: print w/ replies, xml ) Need Help??

If the input were 'y', the first part of the || would be false, but the second part would be true. For an input of 'n', the first part is true while the second is false. Any other input, both parts are true. The only way to avoid the loop if the input is simultaeneously 'y' and 'n'. Only Damian can do that.

I would use shortcut returns to drastically simplify the condition:

sub continue_yn { print "Do you wish to continue the installation (Y/N) : "; $yn=<STDIN>; chomp $yn; LOOP: while ( 1 ) { last LOOP if lc($yn) eq 'y'; last LOOP if lc($yn) eq 'n'; print "Invalid option, please enter an Y or N : "; $yn=<STDIN>; chomp $yn; } print "Valid option entered"; }

Or use a hash to specify the set of valid inputs.

Readonly my %VALID_CHAR => ( y => 1, Y => 1, n => 1, N => 1 ); sub continue_yn { print "Do you wish to continue the installation (Y/N) : "; $yn=<STDIN>; chomp $yn; LOOP: while ( 1 ) { last LOOP if $VALID_CHAR{$yn}; print "Invalid option, please enter an Y or N : "; $yn=<STDIN>; chomp $yn; } print "Valid option entered"; }

WARNING: not tested. Provided for concepts, not cut-and-paste.

As Occam said: Entia non sunt multiplicanda praeter necessitatem.


In reply to Re: Silly While Loop Problems by TomDLux
in thread Silly While Loop Problems by gsus

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • Outside of code tags, you may need to use entities for some characters:
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?
    Username:
    Password:

    What's my password?
    Create A New User
    Chatterbox?
    and the web crawler heard nothing...

    How do I use this? | Other CB clients
    Other Users?
    Others lurking in the Monastery: (12)
    As of 2014-12-22 17:00 GMT
    Sections?
    Information?
    Find Nodes?
    Leftovers?
      Voting Booth?

      Is guessing a good strategy for surviving in the IT business?





      Results (121 votes), past polls