Beefy Boxes and Bandwidth Generously Provided by pair Networks
Pathologically Eclectic Rubbish Lister

Comment on

( #3333=superdoc: print w/replies, xml ) Need Help??

Sorry to be rude, but you really don't seem to have a clue what you are doing.

This is a completely redundant use of threading:

push (@threads, threads->new(\&Process_Output, $ssh, $proc )); while ( $thread = shift @threads ) { @output=$thread->join(); }

You create a thread and push its handle onto @threads. You then immediately shift that handle off of the array and join it.

  1. There is no point in using an array here, because it will only ever contain at most one handle.
  2. Which makes using the while loop redundant because it will only ever iterate once.

    It is exactly equivalent to:

    $thread = threads->new(\&Process_Output, $ssh, $proc ); if( $thread ) { @output = $thread->join(); }

    Which is equivalent to :

    $thread = threads->new(\&Process_Output, $ssh, $proc ); @output = $thread->join();

    Which is exactly equivalent to this:

    @output = threads->new(\&Process_Output, $ssh, $proc )->join();

    Which is exactly equivalent to:

    @output = Process_Output( $ssh, $proc );

    Except that the latter will work. (Of course, it won't speed things up. But neither will what you have now.) But it will work.

The reason your code is crashing is because you are creating an instance of Net::SSH::Expect in one thread, and trying to use it in another.

Why? Why not create the object in the thread where you are going to use it?

With the rise and rise of 'Social' network sites: 'Computers are making people easier to use everyday'
Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
"Science is about questioning the status quo. Questioning authority".
In the absence of evidence, opinion is indistinguishable from prejudice.

The start of some sanity?

In reply to Re^3: Need help with Perl multi threading by BrowserUk
in thread Need help with Perl multi threading by ashok.g

Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":

  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?

    What's my password?
    Create A New User
    and all is quiet...

    How do I use this? | Other CB clients
    Other Users?
    Others taking refuge in the Monastery: (8)
    As of 2018-04-23 14:27 GMT
    Find Nodes?
      Voting Booth?