Beefy Boxes and Bandwidth Generously Provided by pair Networks
No such thing as a small change
 
PerlMonks  

Comment on

( #3333=superdoc: print w/ replies, xml ) Need Help??
Hi, and welcome to Perlmonks! Here's my take on your code:

Find for the following line. It's in the first inner for-loop.
$offsetpattern .= chr((ord(@karray[i])+ord(@karray[i2])+ ord($offset2[ +$i % length($key)]))%256);

Notice that you have the bare variables i and i2. They ought to be $i and $i2 instead (you forgot the $). Also, the array @offset2 is not defined yet at this code point. Plus, indexing into an array should be $karray[$i] instead of @karray[$i].

Then, I notice that you call ord and chr a lot. You are joining characters only to split them later again, and that is (wasted) redundant work. In the case of the key array, you can start off by mapping the ordinals:
my @karray = map ord, (split //, $key);

That saves you the work of calling ord like ord($karray[$i2]) a whole bunch of times. This can also apply to your offset arrays. Keeping all your array elements as ordinals will make your code more concise; no need for intermediate strings.

By the way:
my @karray = map ord, (split //, $key); my $len = length($key); # prints true for both print "true" if $len == @karray; print "true" if $len-1 == $#karray;

In reply to Re: Perl Cipher & questions on semantics/layout optimisation. by repellent
in thread Perl Cipher & questions on semantics/layout optimisation. by Pseudomander

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • Outside of code tags, you may need to use entities for some characters:
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?
    Username:
    Password:

    What's my password?
    Create A New User
    Chatterbox?
    and the web crawler heard nothing...

    How do I use this? | Other CB clients
    Other Users?
    Others chanting in the Monastery: (15)
    As of 2014-07-23 17:31 GMT
    Sections?
    Information?
    Find Nodes?
    Leftovers?
      Voting Booth?

      My favorite superfluous repetitious redundant duplicative phrase is:









      Results (148 votes), past polls