Beefy Boxes and Bandwidth Generously Provided by pair Networks
Welcome to the Monastery
 
PerlMonks  

Comment on

( #3333=superdoc: print w/ replies, xml ) Need Help??

When I compile your code I get:

$ perl -c 959680.pl Type of arg 1 to push must be array (not scalar dereference) at 959680 +.pl line 95, near "@list;" Type of arg 1 to push must be array (not scalar dereference) at 959680 +.pl line 96, near "@callers;" Type of arg 1 to push must be array (not scalar dereference) at 959680 +.pl line 112, near "@list;" 959680.pl had compilation errors.

Which refers to these three lines:

95 push $id, @list; 96 push $id, @callers; 112 push $id, @list;

The first argument to push must be an array.    Perhaps you meant:

95 push @list, $id; 96 push @callers, $id; 112 push @list, $id;


If I enable warnings I get these messages:

$ perl -Mwarnings -c 959680.pl Name "main::key" used only once: possible typo at 959680.pl line 232. Name "main::savestate" used only once: possible typo at 959680.pl line + 65. Name "main::job_list" used only once: possible typo at 959680.pl line +123. Name "main::message" used only once: possible typo at 959680.pl line 6 +3. 959680.pl syntax OK

In reply to Re: Code Review Time! by jwkrahn
in thread Code Review Time! by linuxkid

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • Outside of code tags, you may need to use entities for some characters:
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?
    Username:
    Password:

    What's my password?
    Create A New User
    Chatterbox?
    and the web crawler heard nothing...

    How do I use this? | Other CB clients
    Other Users?
    Others having an uproarious good time at the Monastery: (9)
    As of 2014-07-29 09:24 GMT
    Sections?
    Information?
    Find Nodes?
    Leftovers?
      Voting Booth?

      My favorite superfluous repetitious redundant duplicative phrase is:









      Results (212 votes), past polls