Kudos on the amusing node title.
And your coding style did not cause me to pull a face.
That said, I made some minor "improvements" based on my personal taste:
sub logger {
my $entry = shift;
my $logpath = 'C:\\Logs\\MailServer\\';
my ($sec,$min,$hour,$mday,$mon,$year,$wday,$yday,$isdst) = localti
+me;
my $datestamp = sprintf '%04d_%02d_%02d', 1900+$year, 1+$mon, $mda
+y;
my $timestamp = sprintf '~<%02d:%02d:%02d>~', $hour, $min, $sec;
my $logname = $logpath . $datestamp . '.log';
my $logline = $timestamp . $entry;
if (defined $entry) {
open my $LOG, '>>', $logname or die "open: '$logname': $!";
say $LOG $logline or die "say: '$logname': $!";
say $logline;
close $LOG;
}
}
Note the minor differences and make up your own mind.
In particular, note the use of sprintf so that the dates and
times are formatted more uniformly and thus sort correctly.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.