Beefy Boxes and Bandwidth Generously Provided by pair Networks
good chemistry is complicated,
and a little bit messy -LW
 
PerlMonks  

Comment on

( #3333=superdoc: print w/ replies, xml ) Need Help??

Hello again!

I`ve actually managed to crete my serverside perl script for creating and/or overwriting an existing json file for my JSONP script. But my perl script is kinda weird. I had to open file 2 times, truncate it and the process looks not reliable... or it`s ok...

I need a quick review and an info if the script is good to go or it must undergo some maintenance.

#!/opt/lampp/bin/perl use strict; use CGI; ##### S U B S ######### sub speaker { my $text = shift; print "Content-type: text/html\n\n"; print $text; } sub makeJSON { #create and record a JSON file my ( $name, $mail, $pass ) = @_; if ( system("ls -l | grep datafile.json") == 0 ) { my $replace_me =""; #the storage for replace; my $jobj = "\n \t\t{ \"name\":\t\"$name\",\n\t\t\"mail\":\t\"$ +mail\",\n\t\t\"pass\":\t\"$pass\",\n\t\t },\n];"; open (FH, "</opt/lampp/htdocs/datafile.json") or die("can`t op +en filehandle: $!\n"); while ( <FH> ) { if ( /\]/ ) { $replace_me .= $jobj; } else { $replace_me .= $_; } } close(FH); #truncate and create again open (FR, ">/opt/lampp/htdocs/datafile.json") or die("can`t op +en filehandle: $!\n"); print FR $replace_me; close(FR); } else { my $jobj = "var user = [ \n\t\t{ \"name\":\t\"$name\",\n\t\t\" +mail\":\t\"$mail\",\n\t\t\"pass\":\t\"$pass\",\n\t\t },\n];"; open (FH, ">/opt/lampp/htdocs/datafile.json") or die("can`t op +en filehandle: $!\n"); print FH $jobj; close(FH); } print "Content-type: text/html\n\n"; print "<p>Finished file</p>"; } ################################################## my $q = CGI->new(); my ($name, $mail, $pass) = ( $q->param('name'), $q->param('mail'), $q->param('pass'), ); makeJSON($name, $mail, $pass);

THanks in advance


In reply to File handling? How to make the better one? by heatblazer

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?
    Username:
    Password:

    What's my password?
    Create A New User
    Chatterbox?
    and the web crawler heard nothing...

    How do I use this? | Other CB clients
    Other Users?
    Others scrutinizing the Monastery: (8)
    As of 2015-07-06 09:44 GMT
    Sections?
    Information?
    Find Nodes?
    Leftovers?
      Voting Booth?

      The top three priorities of my open tasks are (in descending order of likelihood to be worked on) ...









      Results (71 votes), past polls