Firstly, there is no need in nested if's:
if ((eval "$hash{$filter[0]->[0]} $filter[0]->[1] $filter[0]->[2]") &&
+
(eval $hash{$filter[1]->[0]} $filter[1]->[1] $filter[1]->[2]) &&
(eval "$hash{$filter[2]->[0]} $filter[2]->[1] $filter[2]->[2]"))
{
print OUTFILE $line, "\n";
}
Secondly, you have quotes (") missing in the second statement. This can be the source of the problem. You can try using other quoting operators.
Thirdly, it can be safer to write a specific function to perform any needed checks on your data:
sub check {
my ($a, $check, $b) = @_;
if ($check eq "==") {
return $a == $b;
} elsif ($check eq ">=") {
return $a >= $b;
} elsif ($check eq "<=") {
return $a <= $b;
} elsif ($check eq "eq") {
return $a eq $b;
} else { die "Unimplemented check $check" }
}
if (&check($hash{$filter[0]->[0]},$filter[0]->[1],$filter[0]->[2]) &&
+&check(...) && &check(...)) {
print OUTFILE $line;
}
Some syntax problems caused by special characters inside the strings will be also avoided by this method.
Sorry if my advice was wrong.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.