A few formatting comments:
I think qq and combined statements are clearer here:
if ($shpath) {
#print SH "chmod 700 $shpath/shell_$ts.sh\n";
#print SH "$shpath/shell_$ts.sh\n";
#print SH "rm $shpath/shell_$ts.sh\n";
#push @cmd, "pscp -pw \"${passwd}\" \"${shell}\" ${user}\@${serv
+er}:${shpath}/shell_$ts.sh\n";
#push @cmd, "plink -batch -pw \"${passwd}\" ${user}\@${server} -
+m \"${sh}\" >> \"${output}\" 2>${outerr}\n";
print SH "chmod 700 $shpath/shell_$ts.sh\n",
"$shpath/shell_$ts.sh\n",
"rm $shpath/shell_$ts.sh\n";
push @cmd, qq[pscp -pw "${passwd}" "${shell}" ${user}\@${server}
+:${shpath}/shell_$ts.sh\n],
qq[plink -batch -pw "${passwd}" ${user}\@${server} -m
+ "${sh}" >> "${output}" 2>${outerr}\n];
} else {
...
You have many "if it begins with X, trim off X" cases that can be simplified:
#if ($sqlline =~ /^=/) { # Convert the output to record v
+iew if prefixed by =
# $sqlline =~ s/^=//; # trim off the =
if ($sqlline =~ s/^=//) { # trim off '=' and convert recor
+d view if prefixed by =
$rsql = 1;
}
And maybe:
#$server =~ s/\s+.*//;
#$user =~ s/\s+.*//;
#$passwd =~ s/\s+.*//;
#$dbconn =~ s/\s+.*//;
#$dbuser =~ s/\s+.*//;
#$dbpasswd =~ s/\s+.*//;
#$shpath =~ s/\s+.*// if $shpath;
map{$_ && s/\s.*//} $server,$user,$passwd,$dbconn,$dbuser,$dbpassw
+d,$shpath;
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
Outside of code tags, you may need to use entities for some characters:
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
|
|