Hi,
Please, format your post question effectively
Even when that is done. There are other some other best practice I think you should still look into.
- Avoid barewords usage like FILE, FH, etc. Instead use a lexically scoped variable like $fh etc
- use use warnings; use strict;
- use the 3 argument open function like so:open my $fh, '<',"config.txt" or die "cannot open file : $!";
- Close your file handles like so: close $fh or die "can't close file: $!";
- Your construction here will only print "1", after you have corrected the syntax error
Use this instead:
...
while(<$fh>){
chomp;
(my $ip =
$_) =~ m/(\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})/;
print $ip,$/;
}
...
I think is even alot better to TEST each of your matched value using "if" like so:
...
while (<$fh>) {
chomp;
my $ip="";
if (m/(?<matched_ip>(\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}))/){
$ip = $+{matched_ip};
}
print $ip,$/;
}
...
Hope this helps
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
Outside of code tags, you may need to use entities for some characters:
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
|
|