sub is_fibonnacci {
my $plus = (5 * $_[0] * $_[0]) + 4;
my $mins = (5 * $_[0] * $_[0]) - 4;
return is_perfect_square($plus) | is_perfect_square($mins);
}
No need to calculate 5 * $_[0] * $_[0] twice, and you probably meant to use the logical or operator instead of the bit-wise or operator.
sub is_fibonnacci {
my $plus = (5 * $_[0] * $_[0]) + 4;
my $mins = $plus - 8;
return is_perfect_square($plus) || is_perfect_square($mins);
}
(The logical operators short-circuit so is_perfect_square($mins) will only execute if is_perfect_square($plus) is true.)
sub is_perfect_square {
my $sqrt = int(sqrt($_[0]));
return $sqrt * $sqrt == $_[0];
}
Or just:
sub is_perfect_square { int( $_[0] ** .5 ) ** 2 == $_[0] }
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|