Your point is, of course valid. However, you should test your code before running it. Your or is lower precedence than = (see Operator Precedence and Associativity). This is, for example, why the classic or die construct works so well. This also means your code will never actually sort by string - warnings would have told you that you are performing a comparison in void context. In addition, + is a no-op in unary operator context; you likely meant the numification ("Venus") operator, 0+. This will not suppress the string in numeric context warnings either, since you are still using a string in a numeric context.
If you want to do auto-detection, you'd be better off using the Conditional Operator using looks_like_number from Scalar::Util:
sub cmp_by {
use Scalar::Util 'looks_like_number';
my $result = 0;
for my $term (@_) {
$result ||= looks_like_number($a)
? $a->{$term} <=> $b->{$term}
: $a->{$term} cmp $b->{$term};
}
return $result;
}
#11929 First ask yourself `How would I do this without a computer?' Then have the computer do it the same way.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|