in reply to Re^2: Squarepusher - A Tool To Convert Images To Audio For Oscilloscope X/Y Mode Displays
in thread Squarepusher - A Tool To Convert Images To Audio For Oscilloscope X/Y Mode Displays
Can’t speak for jdporter, but to my way of thinking the loops (C-style instead of foreach-style) are the least of the problems. To my old eyes the major issues are:
$mode never changes, but it’s re-tested each time through the main loop.
The code is monolithic and should be refactored into subroutines (one for each mode).
use warnings; and use strict; are missing, and all the variables are global.
Hope that helps,
Athanasius <°(((>< contra mundum | Iustus alius egestas vitae, eros Piratica, |
|
---|
Replies are listed 'Best First'. | |
---|---|
Re^4: Squarepusher - A Tool To Convert Images To Audio For Oscilloscope X/Y Mode Displays
by jdporter (Paladin) on Feb 04, 2013 at 19:51 UTC |
In Section
Cool Uses for Perl