Aren't variables defined within subroutine valid only for that subroutine? | [reply] |
One thing some beginning programmers (usually of the procedural discipline) often miss is that functions are supposed to be like their mathematical definition, f(x) = expr. That is, they generally take a value or three as input, and return a value as output. They aren't supposed to access variables outside their scope ("globals", as we call them in the programming world). Of course, there are half a dozen of exceptions to that rule.
I can see that you are accessing the variables $clrNr, $tempfil, and $qry. I'll trust that the latter two are OK as globals, but the first one probably isn't. Here's how we pass it to your function:
sub kundNytt {
my ($trans) = @_;
# do something with $trans
}
And here is how you call it.
$clrNr = 42;
kundNytt($clrNr);
Your code, as it is currently, is fragile, and relies on $clrNr being correctly set before the function is called. It will break sooner or later. Seeing that functions are akin to their mathematical definition helps produce code that is much easier to understand and more reliable.
Ah, this is probably covered in pretty much every programming book written in the last three decades. You could read one :) | [reply]
[d/l]
[select] |
Hej all of you Anonimous Monks (couse I'm not sure if you are the same one posting all of the replies)
First of all, thank you for your time. I now understand use of return much better and will for sure benefit from that in the future. I see already where I need to modify my code. But I probably wouldn't get it if you didn't mention mathematical definition. And as for reading, believe me I've read a (and still reading) Llama book, Camel book, CGI programming with perl, Intermediate Perl, Perl best practices, Perl cookbook. But when you're close to 50 it's not that easy to learn a new language (especially if it's not from your language group). That is as easy as learning Serbian if you are German or learning Swedish if you're Spanish, or learning Franch if you are Chinese. But I'm giving my best with "learning-by-doing" :-) Thanks again
| [reply] |
Aren't variables defined within subroutine valid only for that subroutine? Sure (lexicals are), unless you return them
| [reply] |
| [reply] |