substitute within elements of array

[Dr Manhattan]

Hi Monks

I have an array full of words. Some of them ending with ,|?|! etc. I want to remove/substitute these charcters so words like 'what?' just becomes 'what'.

I tried this-

foreach my $word (@array)
{
   $word =~ s/(\.|\?|\!)$//;
}

foreach my $word (@array)
{
   print "$word\n";
}

but sadly it does not work

[kcott]

G'day Dr Manhattan,

You say "... ending with ,|?|! ..." but your regex (s/(\.|\?|\!)$//) isn't removing commas. Is that the bit that isn't working? You really need to show your input and output: "it does not work" is an entirely inadequate error report.

I think you'd be better off with a single character class ([?!,]) than an alternation with all those escaped characters:

$ perl -Mstrict -Mwarnings -E '
    my @words = ("what?", "what!", "what,");
    say for map { s/[?!,]$//; $_ } @words;
'
what
what
what

[choroba]

Works for me. What exactly is in the @array?

#!/usr/bin/perl
use warnings;
use strict;

my @array = qw/what what? what. what!/;

foreach my $word (@array)
{
   $word =~ s/(\.|\?|\!)$//;
}

foreach my $word (@array)
{
   print "$word\n";
}

Output:

what
what
what
what

[Anonymous Monk]

but sadly it does not work

Sure it does

@array = qw[ SURE! IT! DOES! ];
foreach my $word (@array)
{
   $word =~ s/(\.|\?|\!)$//;
}
die "@array";
__END__
SURE IT DOES at - line 6.

What is the reason you didn't post your @array?