in reply to Can I clean this up??
First off consider what the if statement is doing:
Secondly consider using a pipe instead of writing to a file:
What? more elegant?.....um, it's arguable.
open(FIL,">>$myfil") || die "No open for ct tot: $! \n"; if($ct == 1){ print FIL "\n$ct is down at this time.\n"; } elsif($ct >= 2){ print FIL "\n$ct are not available at this time.\n"; } system("mailx -s 'Mail header' myemail < $myfil"); close(FIL);
Secondly consider using a pipe instead of writing to a file:
Try some common Perl tricks:open(MAIL,"|mailx blah) || die "No mail stuff: $! \n"; if($ct == 1){ print MAIL "\n$ct is down at this time.\n"; } elsif($ct >= 2){ print MAIL "\n$ct are not available at this time.\n"; } close(MAIL);
# Removed brackets, replaced || with or due to higher presedence and r +eadability # used single quotes on uninterpolated strings. open MAIL,'|mailx blah' or die "No mail stuff: $!\n"; # Stuck the if statements at the end so it's more natural. print MAIL "\n$ct is down at this time.\n" if $ct == 1; print MAIL "\n$ct are not available at this time.\n" if $ct >= 2; close(MAIL);
What? more elegant?.....um, it's arguable.
open(MAIL,"|mailx blah) || die "No mail stuff: $! \n"; SWITCH: { $ct >= 2 && { print MAIL "\n$ct are not available at this time.\n +"; last SWITCH }; $ct == 1 && { print MAIL "\n$ct is down at this time.\n"; last SW +ITCH }; } close(MAIL);
--
Brother Frankus.
¤
|
---|
Replies are listed 'Best First'. | |
---|---|
Re: Re: Can I clean this up??
by PhiRatE (Monk) on Jul 24, 2002 at 21:59 UTC | |
Re: Re: Can I clean this up??
by Anonymous Monk on Jul 24, 2002 at 12:03 UTC |
In Section
Seekers of Perl Wisdom