in reply to Re^2: Need help with Validation script
in thread Need help with Validation script
I'm not sure exactly what feed back you are looking for on this code, but I have a couple of comments:
- Be careful passing around barewords. Use strict and warnings to catch this. In your code, I'm specifically referring to this line:
Which will error under strictures and who knows what it will do otherwise. Instead, make sure you quote the words:validate_fields(EACH, P_DLRUOM);
or:validate_fields('EACH', 'P_DLRUOM');validate_fields( qw( EACH P_DLRUOM ) ); - You are checking for the return value of your coderef, but the coderef you call doesn't actually explicitly return anything. In its current state, it will always return true, or rather, it will return the result of the print statement, as it is the last thing that happens in the subroutine
- This doesn't make a big difference, but be careful about how you pass arguments. validate_p_dlruom only looks at the first argument, but you pass two. Generally, I like to do this:
Then you have a better idea of what you are passing around and you don't have to rely on the order in which they are passed.foo( { arg1 => 'val1', arg2 => 'val2' } ); sub foo{ my $arg_ref = shift; # do some stuff with $arg_ref->{arg1} and # $arg_ref->{arg_2} ... return; }
perl -e 'split//,q{john hurl, pest caretaker}and(map{print @_[$_]}(joi +n(q{},map{sprintf(qq{%010u},$_)}(2**2*307*4993,5*101*641*5261,7*59*79 +*36997,13*17*71*45131,3**2*67*89*167*181))=~/\d{2}/g));'
|
---|
Replies are listed 'Best First'. | |
---|---|
Re^4: Need help with Validation script
by ssmith001 (Initiate) on Jul 16, 2007 at 20:13 UTC |
In Section
Seekers of Perl Wisdom