File reade and recreate

[adriang]

Hi all,

I want to create a counter using a file but this don't work

#!/usr/bin/perl
use warnings;
use strict;
use Carp;

open(my $count_file,"+<","count.txt") or croak "cant open";
my $count=<$count_file>;
$count++;
print $count_file $count;
print $count;

__END__

only this work:

#!/usr/bin/perl
use warnings;
use strict;
use Carp;

open(my $count_file,"<","count.txt") or croak "cant open";
my $count=<$count_file>;
$count++;
open($count_file,">","count.txt") or croak "cant open";
print $count_file $count;
print $count;

__END__

I want to use OPEN only once.

Thanks in advace, Adrian.

[GrandFather]

Add:

seek $count_file, 0, 0;

before the print $count_file $count; in your first version of the code.

[adriang]

Super, Thanks.

[MidLifeXis]

You may also want to research how to lock the file from read through write. If multiple processes have the opportunity of simultaneous execution, you have a race condition where you can get anything from the correct behavior to missing one of the updates, to corrupting the data in the file.

In this case I don't think you have the possibility of corruption (that scenario can happen more easily on files with larger datasets), but you may miss one of the updates. ProcA starts and reads the counter. ProcB gets control, reads the counter (same value), increments, and writes the counter. ProcA now resumes, increments the (now outdated) counter, and writes it. Your counter is now one less than it should be.

[adriang]

Thanks for the suggestion

    open($file_read,"+<","$file") or croak "cant open $file for read";
    flock($file_read,2);
    my $count=<$file_read>;
    $count++;
    seek($file_read, 0, "0");
    print $file_read $count;
    flock($file_read,8);
    close($file_read);