I liked your code. A few suggestions, but also not tested!
- Use "/" instead of "\\" for windows file paths
- I think some extra filtering is necessary on the $namesIn file?
- for opendir, add a die message if fails
- for readdir, skip all but simple files - maybe here makes no difference, but I would do it.
Perhaps something like this???
#!usr/bin/perl
use strict;
use warnings;
my $files = "C:/Directory";
my $list = "C:/Test.sdf";
my %keepList;
open my $namesIn, '<', $list or die "Failed to open file: $!\n";
# minor updates to this loop #####################
while (my $line = <$namesIn>) #updated #######
{
my $sdf_file;
#next unless ($sdf_file) = $line =~ /(\w+\.nfo)"$/;
#this regex should work equally well
next unless ($sdf_file) = $line =~ /(\w+\.nfo)/;
$keepList{$sdf_file} = 1;
print "keeping $sdf_file\n"; #update for debugging #######
}
close $namesIn;
opendir my ($filesScan), $files or die "unable to open dir $!";
while (my $filename = readdir $filesScan)
{
next unless -f "$files/$filename"; #only simple files allowed
#skip . and .. or other dirs
next if exists $keepList{$filename};
unlink "$files/$filename" or warn qq{cannot delete $filename: $!+}
+;
}
closedir $filesScan;