Beefy Boxes and Bandwidth Generously Provided by pair Networks
Welcome to the Monastery
 
PerlMonks  

Re: Reading cookie expired date

by CountZero (Bishop)
on Apr 08, 2012 at 10:45 UTC ( [id://963989]=note: print w/replies, xml ) Need Help??


in reply to Reading cookie expired date

For sure someone else will answer you about the cookies, but, please tell me:
  1. Wy do you use local here? I think you want to use lexical variables here and those are declared with the my keyword.
  2. Why did you prefix your subroutine calls with the & sigil? Are these subroutines prototyped and you want to avoid the prototype checks? write_cookies isn't prototyped so you should drop the &. It serves no useful purpose.
Also, I try not to have variables inside my subroutines that are not passed in as parameters, unless it are really and truly global variables:
sub write_cookies{ my ($username, $password, $regtype, $expires) = @_; print "Set-Cookie: reguser=$username; expires=$expires; path=/;\n +"; print "Set-Cookie: regpass=$password; expires=$expires; path=/;\n +"; print "Set-Cookie: regtype=$regtype; expires=$expires; path=/;\n" +; }
And then call the sub as follows:
write_cookies($username, $password, $regtype, calc_cookie_expires(-1)) +;

CountZero

A program should be light and agile, its subroutines connected like a string of pearls. The spirit and intent of the program should be retained throughout. There should be neither too little or too much, neither needless loops nor useless variables, neither lack of structure nor overwhelming rigidity." - The Tao of Programming, 4.1 - Geoffrey James

My blog: Imperial Deltronics

Replies are listed 'Best First'.
Re^2: Reading cookie expired date
by htmanning (Friar) on Apr 08, 2012 at 19:29 UTC
    CountZero - You're probably right. Someone else wrote these routines years ago and now I have to try and hack them up. But, the short answer is I don't really know what I'm doing. Wish I did. Thanks.

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://963989]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others cooling their heels in the Monastery: (6)
As of 2024-04-19 16:08 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found