Beefy Boxes and Bandwidth Generously Provided by pair Networks
No such thing as a small change

Re: Extracting code into a subroutine

by grizzley (Chaplain)
on Oct 31, 2012 at 09:59 UTC ( #1001633=note: print w/replies, xml ) Need Help??

in reply to Extracting code into a subroutine

First write differences down. Then design subroutine arguments. Then desing subroutine. What are the differences?
  • List of field indexes.
  • grep regexp (NETPACKET, NETERROR)
  • grep regexp (Network, Busy, Memory)
  • what to do with arguments?
  • others?
Then subroutine arguments:
sub yoursub { my ($rangearrayref, $firstre, $secondre, $subref) = @_; ... } yoursub([2..7], 'NETPACKET', 'Network', \&transformNetpacketSub);
or hash style:
sub yoursub { my %args = @_; my ($rangearrayref, $firstre, $secondre, $subref) = ($args{-range}, +$args{-firstre}, $args{-secondre}, $args{-transformsub}); ... } yoursub(-range => [2..7], -firstre=>'NETPACKET', -secondre=>'Network', + ->transformsub=>\&transformNetpacketSub);
And then the only problem is to write proper transformNetpacketSub. I would do it like this:
sub transformNetpacketSub { my $str = shift; # do anything with string return $str; }

Replies are listed 'Best First'.
Re^2: Extracting code into a subroutine
by cunningrat (Novice) on Oct 31, 2012 at 13:27 UTC
    Thanks to all who responded. It definitely gave me some ideas on how to proceed, which was all I needed.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1001633]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others wandering the Monastery: (6)
As of 2016-10-23 07:32 GMT
Find Nodes?
    Voting Booth?
    How many different varieties (color, size, etc) of socks do you have in your sock drawer?

    Results (300 votes). Check out past polls.