Beefy Boxes and Bandwidth Generously Provided by pair Networks
There's more than one way to do things
 
PerlMonks  

Re: create .ncx files

by CountZero (Bishop)
on Jan 08, 2013 at 17:26 UTC ( #1012292=note: print w/ replies, xml ) Need Help??


in reply to create .ncx files

This is your actual program:

open( FH, "+>toc1.ncx" ); $OH1 = select(FH); open( FILE, 'b.txt' ) or die "$!"; while (<FILE>) { if ( m/^(ISBN Number|book title|Cover|Half|Title|Copyright|Content|Preface) +:(.*)/ ) { push( @arr, $2 ); } }
Your print statement will never execute as it was turned into a comment.

So what is your question? Assume we know nothing about ".ncx"-files.

Some very preliminary comments are:

  1. You are not using "use strict; use warnings;
  2. You are using two argument open rather than the three argument version.
  3. You are not using lexical filehandles.
  4. "Kidnapping" the standard out filehandle and pointing it to a file is probably a bad idea. It is better to use an explicit filehandle in your print-statements.

CountZero

A program should be light and agile, its subroutines connected like a string of pearls. The spirit and intent of the program should be retained throughout. There should be neither too little or too much, neither needless loops nor useless variables, neither lack of structure nor overwhelming rigidity." - The Tao of Programming, 4.1 - Geoffrey James

My blog: Imperial Deltronics


Comment on Re: create .ncx files
Select or Download Code

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1012292]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others imbibing at the Monastery: (11)
As of 2014-10-23 13:50 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    For retirement, I am banking on:










    Results (125 votes), past polls