Beefy Boxes and Bandwidth Generously Provided by pair Networks RobOMonk
Think about Loose Coupling
 
PerlMonks  

Re^2: Bug in script, regex help req extreme urgent

by sid.verycool (Novice)
on Mar 09, 2013 at 18:37 UTC ( #1022602=note: print w/ replies, xml ) Need Help??


in reply to Re: Bug in script, regex help req extreme urgent
in thread Bug in script, regex help req extreme urgent

1 confession, this code was written my 1 of my colleagues who left and i have to fix it. I'm trying to understand what this script exactly wants (specially the regex in my $string), so that any of my changes dont break original intent of script. Plz help me in understanding its objective and how can i transform it to read thru line by line, which is i think the easier way (atleast for a newbie like me) and yes if in the comment we change OLD to new it wud b gr8 because that is also wrong (although comments lie ;) shell#> script.pl file NEW OLD

#!/usr/bin/perl -w BEGIN {undef $/;} my $match = "module.*?$ARGV[2].*?([\\(;])"; my $filename = $ARGV[0]; open (INFILE, "<", $filename) or die "Failed to read file $filename +: $! \n"; $string = <INFILE>; close INFILE; $string =~ s/$match/module $ARGV[1]$1/sg; open OUTFILE, ">$ARGV[0]" || die "Failed to create $ARGV[0]\n"; print OUTFILE ($string); close OUTFILE;


Comment on Re^2: Bug in script, regex help req extreme urgent
Download Code
Re^3: Bug in script, regex help req extreme urgent
by pvaldes (Hermit) on Mar 09, 2013 at 21:53 UTC
    we change OLD to new it wud b gr8 because that is also wrong

    Can not understand this language, sorry. Maybe you need to provide a better example?.

Re^3: Bug in script, regex help req extreme urgent
by jaredor (Deacon) on Mar 10, 2013 at 05:13 UTC

    If you want a likely story to explain things, then here's mine: Your colleague wanted to change an entire module definition file "in place" but didn't want to use a temporary file.

    On a Unix-type command line, you can do the same thing with

    perl -pie 's/\b module \s+ OLD \b/module NEW/xms;' file_name

    But back to your script. Your colleague didn't have to slurp the file into a single variable, he or she could have read the file into an array. The amount of memory taken up would have roughly been the same and the text processing could then have been done line-by-line.

    I don't know what relevant CPAN modules are out there to make in-place text file processing easier, but I'd bet there are some. For your emergency need right now the other excellent answers in this thread should give you enough to deliver something.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1022602]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others contemplating the Monastery: (14)
As of 2014-04-18 17:48 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    April first is:







    Results (471 votes), past polls