Beefy Boxes and Bandwidth Generously Provided by pair Networks
laziness, impatience, and hubris

Re: Problem with substr

by kennethk (Abbot)
on May 14, 2013 at 16:03 UTC ( #1033518=note: print w/replies, xml ) Need Help??

in reply to Problem with substr

If rindex has no matches, it returns -1. If substr gets a negative OFFSET, it "starts that far back from the end of the string". The correct approach here would be to test the result of rindex, and only modify if the number is non-negative:
if ((my $index = rindex( $name, q{.replaced})) > -1 ) { $name = substr $name, 0, $index; }

Note as well that you have an off-by-one error on your replacement, which I have fixed by adding '.' to your string.

Update: AnomalousMonk caught that the rindex was in the LENGTH argument, not the OFFSET argument.

If LENGTH is negative, leaves that many characters off the end of the string.

#11929 First ask yourself `How would I do this without a computer?' Then have the computer do it the same way.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1033518]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others examining the Monastery: (5)
As of 2016-12-09 01:28 GMT
Find Nodes?
    Voting Booth?
    On a regular basis, I'm most likely to spy upon:

    Results (148 votes). Check out past polls.