Beefy Boxes and Bandwidth Generously Provided by pair Networks
XP is just a number

RFC - Perl::Critic policy to allow "my $self = shift;" to be valid for unpacking @_

by boftx (Deacon)
on Sep 23, 2013 at 03:31 UTC ( #1055226=perlmeditation: print w/replies, xml ) Need Help??

This is not only an RFC, but also a Request For Help.

In short, when I run this new policy against a simple test file I see the results I want, but it fails the regression test I've included from Perl::Critic. Beyond that, I would like suggestions for what config opitions might be desirable as well as help with documentation changes such as credits, etc.

The new policy project can be found on GitHub in the devel branch:

The following must be in the .perlcriticrc file:

exclude = Subroutines::RequireArgUnpacking include = Local::RequireArgUnpackOrShift

Those entries will allow the new policy to be picked up while at the same time disabling the policy it is intended to replace (assuming you are in the lib directory of the distro.)

The regression test can be run as you would expect from the top dir in the distro:

$ prove -l t

Again, assuming you are in the lib dir in the distro, you can run this command to test a given file and use the new policy:

$ perlcritic <path-to-file>/

Here is the source for

[~/perl/test]# cat package CriticTest; use Moose; our $VERSION = '1.01'; has 'needs_build' => ( isa => 'Int', is => 'rw', lazy => 1, builder => '_build_needs_build', ); sub _build_needs_build { my $self = shift; my %args = @_; return $self; } 1; __END__

Please feel free to to leave comments (good, bad and ugly) here or on Git. I feel this could be a welcome additon on CPAN if I can work out the kinks with your kind help.

On time, cheap, compliant with final specs. Pick two.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: perlmeditation [id://1055226]
Approved by Corion
Front-paged by sparkyichi
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others musing on the Monastery: (4)
As of 2017-08-23 14:13 GMT
Find Nodes?
    Voting Booth?
    Who is your favorite scientist and why?

    Results (353 votes). Check out past polls.