Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl-Sensitive Sunglasses
 
PerlMonks  

Re: How to deal with old OO code that mixes instance methods with class methods

by GrandFather (Cardinal)
on Dec 21, 2013 at 09:18 UTC ( #1068021=note: print w/ replies, xml ) Need Help??


in reply to How to deal with old OO code that mixes instance methods with class methods

If it ain't broke, don't fix it. Some stuff to think about:

  • Is there a compelling reason for the calling code to know about implementation details?
  • Is there a compelling run time issue the change would fix?
  • Is there a compelling maintenance issue the change would fix?
  • Are you confident you won't introduce bugs making the change?
  • Does all the affected code have unit tests?
  • Is this the most important thing you can be doing right now?
  • Does this change advance your carer or improve your coding ability?

Not all considerations are completely serious, but decide which are important to you, or if there are others I've missed, and think about those criteria to make your decision.

True laziness is hard work


Comment on Re: How to deal with old OO code that mixes instance methods with class methods

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1068021]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others taking refuge in the Monastery: (21)
As of 2014-10-30 14:36 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    For retirement, I am banking on:










    Results (208 votes), past polls