Re^3: Adding a numeric key to list items and creating a user selection list

[hippo]

The first portion of the print line is supposed to indent the list by 2 spaces. The spaces are being ignored and instead the list is left justified to the edge of the screen.

There are plenty of options for formatted output in Perl. However, the most straight forward (particularly with those familiar with it from other languages) is likely to be printf.

[stevek1974]

I figured that out and used printf to achieve the initial spacing. I also figured out how to accept the comma separated input, however I am having a small issue with this. When it renders the output on the screen, it is separating the numeric identifier from the data. So, what I get is:

Enter Selection(s): 1,3 #this is what the user will input and the results output below

  1. 10.10.10.11
  3
.10.10.10.13

What I expect to see is this

  1. 10.10.10.11
  3. 10.10.10.13

I found that adding a trailing comma to the input 1,3, resolved the issue, but created another warning

Argument "\n" isn't numeric in subtraction (-)

# Import cluster hosts list and print sorted output
print color('bold white') . "The following hosts were found: \n\n" . c
+olor('reset');
use File::Slurp;
my @chosts = read_file($chosts_file);
my @vdbhosts = sort @chosts;
foreach my $i (0..$#vdbhosts ) {
    printf '%-2s',"";
    print $i + 1 . ". $vdbhosts[$i]";
}
print "\n";

ASSIGN_VDB_HOSTS:
# Choose the hosts from the list of above
print "Please select the hosts from the list above separated by commas
+ (1,2,3...)\n";
print "\n";
print "Enter selection(s): ";
my $vdbhostinput = (<>);
print "\n";
my @vdbvalues = split(',', $vdbhostinput);
foreach my $i (@vdbvalues){
     print "  " . $i . ". " . $vdbhosts[$i - 1];
}
print "\n";

[hippo]

Quick fix: chomp your input.

Proper fix: Restore the validation steps from my previous answer.

[stevek1974]

Works like a champ! Now, on to validation. Thanks again!

[stevek1974]

Update

Resolved

Maybe not the best solution but I changed the check to...

foreach my $i (@vdblist){
    
    if ($i == 0){
        print BOLD WHITE ON_RED, "Error: $i does not correspond to a h
+ost in the list!", RESET;
        print "\n\n";
        goto CLUSTER_HOSTS;        
    }
    elsif ($i > scalar $#vdbhosts){
        print BOLD WHITE ON_RED, "Error: $i does not correspond to a h
+ost in the list!", RESET;
        print "\n\n";
        goto CLUSTER_HOSTS;
    }
}

Now it works!