Re: find common data in multiple files

[Discipulus]

Hello mao9856,

Have you run the code you posted? @counts and even more open my A, "<", "@counts "could not open file1 $!"; make no sense at all. Also foreach (@ARGV) makes no sense infact you are never using $_ the implicit variable filled for you by foreach when you do not specify a named variable.

So the beginning of your program must be better wrote as:

use strict;
use warnings;
my %result;

# my @counts=(); # no need of this

foreach (@ARGV) {
  # my $column=0; # no need of this too

  open my $fh, "<", $_ or die "could not open file [$_] $!";
  while (<$fh>) {
              chomp;
              ...

Use print to debug your program: print "DEBUG: working on file [$_]\n" as first line of the loop will confirm you are reading all files.

Then you do not need to split you lines as you want to check for ID121 ABC14 whole presence in every file. So put the whole line as key of the results hash and ++ it as you are doing.

A tip: as you need only strings that are in all files add every entry of the first file and then for following files just ++ keys that are already present in the hash.

L*

[mao9856]

Hello Discipulus I haven't tried the code, but I wrote it based on my understanding. Please excuse me i am very beginner in perl. my @counts=() was wriiten to define number of files so while running this programme i thought I would use: perl prog.pl *.txt And ARGV was used because name of files vary. As per suggestions, i am trying to run new code. Thank you for suggestions:)