Perl Monk, Perl Meditation | |
PerlMonks |
Re: Finding duplicated code in Perlby TomDLux (Vicar) |
on Nov 27, 2003 at 01:01 UTC ( [id://310437]=note: print w/replies, xml ) | Need Help?? |
The code uses system to sleep 2 or 5 seconds. Is it waiting for something to happen? Giving some code a chance to complete? It uses a shell method to copy files and perform other system commands. Are these complicated? on a remote platform? Or simply not built-ins in the original language? I had a similar problem last winter, miles and miles of bad linear code, though in my case the problem was the original codeers, rather than the original language. I keep thinking about writing an article like the ones MJD has, how 3000 lines of bad code can collapse into 137 lines of good code. Begin by reading a few files, getting the feel for what they do. Take one file, edit to reduce repetition, using conditions, loops, etc. Rename poorly named variables, to increase clarity. Refactor code into routines: Top level code shoudl consist of built-in commands, object constrruction, and subroutine calls. Subroutines that actually do the work should be short, a dozen lines, two dozen at the most, and should do one thing. Those routines are used in more complicated routines. This way, it will be easier to share subroutines between files. Don't worry about making one file perfect. Just simplify it and go on to the next; you'll be back to share code, anyway. --
In Section
Seekers of Perl Wisdom
|
|