This:
$line =~ m/\s*(\S+)\s*(\S+)\s*(\S+)\s*(\S+)\s*/;
is a really bad way to split a line on whitespace. It will do all sorts of things you don't want in edge case situations. See this Re: ('Re: ' x 6) How to remove the $1 hard coding and its parent thread.
my ($device, $bps, $sps, $msps ) = split ' ', $line;
Is far more robust, self documenting, and also faster way to split a file like the one you have into fields.
Makes no difference to the functionality but:
sub PlotGraph
{
my $worksheet = shift;
my $col = shift;
my $row = shift;
my $chartTitle = shift;
my $xAxisTitle = shift;
my $yAxisTitle = shift;
# reads better to my eye and makes it easier to see the function(args)
+
# (also a bit faster FWIW)
sub PlotGraph
{
my ( $worksheet, $col, $row, $chartTitle, $xAxisTitle, $yAxisTitle )
+ = @_;
cheers
tachyon
s&&rsenoyhcatreve&&&s&n.+t&"$'$`$\"$\&"&ee&&y&srve&&d&&print
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.