Beefy Boxes and Bandwidth Generously Provided by pair Networks
good chemistry is complicated,
and a little bit messy -LW
 
PerlMonks  

Bad return value from a block with variable localization

by jesuashok (Curate)
on Apr 10, 2006 at 08:09 UTC ( [id://542227]=perlquestion: print w/replies, xml ) Need Help??

jesuashok has asked for the wisdom of the Perl Monks concerning the following question:

Hello all,

I've run into this strange behaviour when playing with trying to make functions return different values from the number of parameters they were called with. If you test @_, and that you return from a do { ... } block where a variable is localized, the return value is undef if you don't add an else statement.

#!/usr/bin/perl -w use strict; sub foo { if (@_) { return do { my $dummy; 1; }; } else { return 0; } } # let's just remove the else sub bar { if (@_) { return do { my $dummy; 1; }; } return 0; } print foo().' '.foo('baz')."\n"; # that was expected print bar().' '.bar('baz')."\n"; # undef
################################################## Expected output: 0 1 0 1 ################################################## Actual output: 0 1 Use of uninitialized value in concatenation (.) or string at ./undef.p +l line 24. 0 ##################################################
"Keep pouring your ideas"

2006-10-07 Unapproved by planetscape once evidence of habitual plagiarism uncovered.

Replies are listed 'Best First'.
Re: Bad return value from a block with variable localization
by BrowserUk (Patriarch) on Apr 10, 2006 at 08:59 UTC

    As a temporary workaround until the bug is fixed, the following seems to 'cure' it and I can't see any other side effects:

    sub bar { if (@_) { return my $x = do { my $dummy; 1; }; } return 0; }

    Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
    Lingua non convalesco, consenesco et abolesco. -- Rule 1 has a caveat! -- Who broke the cabal?
    "Science is about questioning the status quo. Questioning authority".
    In the absence of evidence, opinion is indistinguishable from prejudice.
Re: Bad return value from a block with variable localization
by codeacrobat (Chaplain) on Apr 10, 2006 at 11:41 UTC
    It also helps to actually "return 1;" instead of just "1;" In general use the short form only when you are really at the end of a subroutine. do blocks are not really subroutines.
    #!/usr/bin/perl use strict; use warnings; # let's just remove the else sub foo { if (@_) { return do { my $dummy; return 1; }; } 0; } sub bar { if (@_) { return do { my $dummy; return 1; }; } else { 0; } } print foo() . ' ' . foo('baz') . "\n"; # 1 0 print bar() . ' ' . bar('baz') . "\n"; # also 1 0
    Update:
    I noticed that the above script is bad style for a direct return from the subroutine. You should use eval instead of do. See the example below.
    #!/usr/bin/perl use strict; use warnings; # let's just remove the else sub foo { if (@_) { return 10 + do { my $dummy; return 1; }; } 0; } sub bar { if (@_) { return 10 + eval { my $dummy; return 1; }; } 0; } print foo() . ' ' . foo('baz') . "\n"; # 1 0 print bar() . ' ' . bar('baz') . "\n"; # 11 0
Re: Bad return value from a block with variable localization = PLAGIARISM
by liverpole (Monsignor) on Oct 06, 2006 at 13:52 UTC
    From this site, first posted on March 28, 2006:
    [Please enter your report here] Hello, I've run into this strange behaviour when playing with trying to make functions return different values from the number of parameters they were called with. If you test [at]_, and that you return from a do { ... } block where a variable is localized, the return value is undef if you don't add an else statement. Looks like some parsing bug, but not that I'm good enough to have any real clue about it. Regards, Vincent Pit ################################################################# Test case: (line 1 is #!) #!/usr/bin/perl use strict; use warnings; sub foo { if (@_) { return do { my $dummy; 1; }; } else { return 0; } } # let's just remove the else sub bar { if (@_) { return do { my $dummy; 1; }; } return 0; } print foo().' '.foo('baz')."\n"; # that was expected print bar().' '.bar('baz')."\n"; # undef ################################################################# Expected output: 0 1 0 1 ################################################################# Actual output: 0 1 Use of uninitialized value in concatenation (.) or string at ./bug.pl +line 24. 0 #################################################################

    s''(q.S:$/9=(T1';s;(..)(..);$..=substr+crypt($1,$2),2,3;eg;print$..$/

      And for that, he got 56+ upvotes? :-(

      I propose a moratorium on approving any post by that plagiarist, who without a doubt doesn't actually know one bit of Perl.

        I think that's a very good idea.

        By the way, I discovered this afternoon that [id://madtoperl|another plagiarist] has a similar lack of ethics here, which I've pointed out in the thread which starts here.

        Like jesuashok, madtoperl has been confronted for this illegal behavior numerous times, as I'm sure you're aware.

        If indeed they are the same person, perhaps it's time to ask [id://gods|the gods] for help in tracking their IP address, so that we can put a stop to it.


        s''(q.S:$/9=(T1';s;(..)(..);$..=substr+crypt($1,$2),2,3;eg;print$..$/

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: perlquestion [id://542227]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others sharing their wisdom with the Monastery: (5)
As of 2024-03-19 10:41 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found