Re: How Much Is Too Much (on one line of code)?

[adrianh]

How do you feel about that code snippet?

Too much :-) Mostly because if the trailing if means I have to re-evaluate a fairly complex LHS after I've read it.

I'd also wonder about the hard-coded 'gbr'. Mostly I'd wonder if some other part of the system should "know" what the default country was. However, if this was the only place it was used I'd probably leave it inlined for the moment.

I'd probably re-write it as something like:

sub display_country {
    return unless my $country = $card->country;
    return '' if $country eq 'gbr';
    return uc "[$country]";
}

with appropriate tweaks if the coercion of a false country to under/() in scalar/list was inappropriate in context.

[atemon]

I don’t think it need to be re-written. To avoid confusion, I'd like to put two parenthesis and rewrite the code as



my $country = $card->country;    
$country = (( $country eq 'gbr' ) ? '' : uc "[$country]" )if $country;

rgds
VC
------
If you treat every situation as a life-and-death matter,
you'll die a lot of times.
~Dean Smith~