Beefy Boxes and Bandwidth Generously Provided by pair Networks
P is for Practical

Re^4: Recurring Cycle of Fractions

by Sidhekin (Priest)
on Sep 09, 2007 at 19:53 UTC ( #637929=note: print w/replies, xml ) Need Help??

in reply to Re^3: Recurring Cycle of Fractions
in thread Recurring Cycle of Fractions

That's pretty much the same as my solution, so just a couple of things:

(1): The default precision with bignum (as I used) is good enough for up to 99, but if I want to go above, I need to use higher precision too. Your code fails even earlier. A constant div_scale of 50 only goes so far ... though of course when the list of numbers checked is also constant, I guess I can't fault it.

(2): Your code will break for numbers above 100 (even if you up the div_scale), since every float will begin with "0.00", and your code will see the repeated "0", and think it is the period ... no matter what follows it! Even if you hard code it so that you skip those initial zeros, it will find false positives for other numbers as well: 1/2048 == 0.00048828125, exact, but your code (if fixed to skip the zeros) will find a repeated digit "8" and assume it is the cycle sequence.

(I solve this problem by insisting that there are fewer than COUNT characters remaining after the match and making sure the string is big enough that we get at least two COUNTs worth of cyclying, which also requires keeping trailing zeros.)

So yeah, I guess you were still missing something. :)

print "Just another Perl ${\(trickster and hacker)},"
The Sidhekin proves Sidhe did it!

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://637929]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others pondering the Monastery: (5)
As of 2017-07-26 06:40 GMT
Find Nodes?
    Voting Booth?
    I came, I saw, I ...

    Results (384 votes). Check out past polls.