|Keep It Simple, Stupid|
coverage influencing formby davidrw (Prior)
|on Dec 29, 2007 at 19:42 UTC||Need Help??|
One of the things a like about testing/tests/test suites/coverage stats is that it can sometimes1 (often?) cause re-evaluation of how you wrote some specific piece of code.
I recently wrote a snippet of code of this form:
While there could easily style/preference (or efficiency) arguments made about this form and use of the regex to match for multiple exact matches, it's nice because it's concise and easy to add an extra case or two (i.e. not an extra line, though obviously adding more than just a couple would be messy).
I found myself wanted to rewrite it, however, for a different reason after starting to compose my test suite. A test suite consisting of a call to foo('AAA') and foo('DDD') is sufficient for Devel::Cover to report 100% coverage. But clearly it's not going after the 'BBB' or 'CCC' of the conditional that's embedded in the regex logic.
If, however, it's rewritten as:
or (depending on the innards of the block)
then it requires tests of foo('DDD'), foo('AAA'), foo('BBB'), and foo('CCC') for full coverage.
1. Two other examples of coverage issues causing code changes that i've run into: