Beefy Boxes and Bandwidth Generously Provided by pair Networks
Just another Perl shrine
 
PerlMonks  

Re^3: libwww-perl, POE and Unicode

by Juerd (Abbot)
on May 05, 2008 at 10:36 UTC ( #684603=note: print w/ replies, xml ) Need Help??


in reply to Re^2: libwww-perl, POE and Unicode
in thread libwww-perl, POE and Unicode

This is neither just a test, nor extreme. This snippet is exactly what every octet oriented Perl function should do.

Doubtless, this will "break" some existing code, as it has clearly done in this case. But believe me, clear breakage with a meaningful error message is SO much better than the vague semi-random encoding trouble you could have gotten without it!

An HTTP message is strictly a stream of octets. It is impossible to have unencoded text, because TCP does not support that. If you would try to use the rejected message over a socket, you would get Perl warnings about "wide characters", a sign that Perl is doing the best it can to force the invalid value into an octet form: it UTF-8 encodes and warns about it. However, Perl first tries to downgrade. If that succeeds, it uses the downgraded string and does not complain. This repairs several bugs caused by sloppy programming.

The snippet that you cited does the same thing: downgrade and use the downgraded form, but if it cannot be downgraded (that is: if the string contains a character with an ordinal value greater than 255) to byte form, complain. The way in which it complains is different from Perls built in. This code DIES. Your gain: you now know exactly that there is a problem, and where it is. Without this new addition to LWP you would probably not have know that there was a problem, and if you had, you would probably still be looking for the source. And if you're like most Perl programmers who don't yet fully understand the octet/text separation logic, you would probably have mis-identified something else as the source, and "fixed" it by making your code forward incompatible. Much like PoCoCli::HTTP did.

All I can say is: be glad, very glad, that LWP got this change. The pain it causes is temporarily, and much less than the pain it prevents.

Juerd # { site => 'juerd.nl', do_not_use => 'spamtrap', perl6_server => 'feather' }


Comment on Re^3: libwww-perl, POE and Unicode
Re^4: libwww-perl, POE and Unicode
by polettix (Vicar) on Jun 01, 2009 at 15:31 UTC
    Hi there,

    before posting a bug report, I'd like a comment about why utf8::downgrade() had to be used instead of Encode::encode_utf8().

    The former modifies the input in-place (argh!) and fails if it isn't either Latin-1 or EBCDIC. This means that the behaviour changes depending on the platform, and your odds are gone if your text can't be converted into one of those two encodings (which means a big part of the world).

    The latter would live its input unchanged, would behave the same whatever the platform (I hope) and would thus be truly "octet oriented".

    Do you think a bug report/patch would be well-placed in this case, or am I overlooking something?

    ,

    perl -ple'$_=reverse' <<<ti.xittelop@oivalf

    Io ho capito... ma tu che hai detto?

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://684603]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others browsing the Monastery: (8)
As of 2014-07-13 14:34 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    When choosing user names for websites, I prefer to use:








    Results (250 votes), past polls