P is for Practical PerlMonks

Re: Silly While Loop Problems

by TomDLux (Vicar)
 on Sep 30, 2011 at 18:24 UTC ( #928890=note: print w/replies, xml ) Need Help??

in reply to Silly While Loop Problems

If the input were 'y', the first part of the || would be false, but the second part would be true. For an input of 'n', the first part is true while the second is false. Any other input, both parts are true. The only way to avoid the loop if the input is simultaeneously 'y' and 'n'. Only Damian can do that.

I would use shortcut returns to drastically simplify the condition:

```sub continue_yn
{
print "Do you wish to continue the installation (Y/N) : ";
\$yn=<STDIN>;
chomp \$yn;

LOOP:
while ( 1 )
{
last LOOP if lc(\$yn) eq 'y';
last LOOP if lc(\$yn) eq 'n';
print "Invalid option, please enter an Y or N : ";
\$yn=<STDIN>;
chomp \$yn;
}

print "Valid option entered";
}

Or use a hash to specify the set of valid inputs.

```Readonly my %VALID_CHAR => ( y => 1, Y => 1, n => 1, N => 1 );
sub continue_yn
{
print "Do you wish to continue the installation (Y/N) : ";
\$yn=<STDIN>;
chomp \$yn;

LOOP:
while ( 1 )
{
last LOOP if \$VALID_CHAR{\$yn};
print "Invalid option, please enter an Y or N : ";
\$yn=<STDIN>;
chomp \$yn;
}

print "Valid option entered";
}

WARNING: not tested. Provided for concepts, not cut-and-paste.

As Occam said: Entia non sunt multiplicanda praeter necessitatem.

Create A New User
Node Status?
node history
Node Type: note [id://928890]
help
Chatterbox?
 [Corion]: (this post on nntp.perl.org / p5p makes it seem to me that smoke testers seem to have a blind spot there) [Corion]: Hmmm. Maybe setting \$ENV{PERL5LIB}=" some path without dot"; perl Makefile.PL; make test already is enough to locally test your module... [Corion]: Meh, no, will need a BEGIN hook... [Corion]: ... and PERL5OPT does not like -e in it :-( [Corion]: Ah. The magic invocation is set PERL5OPT=-M-lib=. (equivalent of no lib '.'; [Corion]: )

How do I use this? | Other CB clients
Other Users?
Others drinking their drinks and smoking their pipes about the Monastery: (7)
As of 2017-03-27 08:08 GMT
Sections?
Information?
Find Nodes?
Leftovers?
Voting Booth?
Should Pluto Get Its Planethood Back?

Results (317 votes). Check out past polls.