Beefy Boxes and Bandwidth Generously Provided by pair Networks
Pathologically Eclectic Rubbish Lister
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

Hello Nuke

I'm of the personal opinion that the reason we have come this far without developing a really good standard for code review is that there is no such thing.

As Ferrency points out, there are many reasons that one could possibly want to do a code review. Finding one template that covers all of those would be very hard. For example, a code review done for the purpose of job performance review would probably not be very useful if you were looking for bugs. Likewise, I don't think I would want my performance review to be dependent on the number of bugs in my code. :) One solution might be to have an all-encompasing template to cover all bases. But, the problem with that is it would be so long and/or complicated that nobody would ever want to use it!

pdcawley also touches on an issue that was recently brought up by stephen in Failure To Refactor. That is that not all programmers are working at the same level. Without the same experiences, we don't look at code the same way.

I would suggest that a more fruitful endeavor might be to work on developing a standard template to be given to the reviewer that specifies what is to be reviewed, and how to review it.


In reply to Re: Formal code review specifications and reporting format by ehdonhon
in thread Formal code review specifications and reporting format by Nuke

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others studying the Monastery: (7)
As of 2024-04-23 12:40 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found