A few comments after a quick scan through the code:
- I'm not sure how you are supposed to install this
as a Win32 service (The supplied subs, "Remove", "Install", etc.
don't seem to have anything pointing to them).
- Some of this code looks like it should be refactored:
e.g. the code for minutos and horas are almost identical,
and with some re-writing you could have much simpler
code.
- You're not useing strict or warnings!
- The name of the crontab file is hard-coded in the
script. You should probably document that!
- (And you should probably document that the names of
the days are hard-coded in Spanish, and where to change
them. If you've not learned how to use POD documentation
try reading the perlpod manpage, very useful!)
Hope that helps.
Cheerio!
Osfameron
http://osfameron.perlmonk.org/chickenman/
In reply to Re: Crond
by osfameron
in thread Crond
by zeroquo
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|