Late to the party, again, but one thing nobody has commented on is that your if-structure re-tests the same thing multiple times. Instead of:
if (($genome[$i] eq 'a') && ($genome[$i+1] eq 'a')) { ++$tt; }
elsif (($genome[$i] eq 'a') && ($genome[$i+1] eq 'g')) { ++$a
+g; }
elsif (($genome[$i] eq 'a') && ($genome[$i+1] eq 'c')) { ++$a
+c; }
elsif (($genome[$i] eq 'a') && ($genome[$i+1] eq 't')) { ++$a
+t; }
elsif (($genome[$i] eq 't') && ($genome[$i+1] eq 'a')) { ++$t
+a; }
elsif (($genome[$i] eq 't') && ($genome[$i+1] eq 'g')) { ++$t
+g; }
elsif (($genome[$i] eq 't') && ($genome[$i+1] eq 'c')) { ++$g
+a; }
elsif (($genome[$i] eq 't') && ($genome[$i+1] eq 't')) { ++$t
+t; }
you should have had:
if ($genome[$i] eq 'a') {
if ($genome[$i+1] eq 'a') { ++$tt; }
elsif ($genome[$i+1] eq 'g') { ++$ag; }
elsif ($genome[$i+1] eq 'c') { ++$ac; }
elsif ($genome[$i+1] eq 't') { ++$at; }
}
elsif ($genome[$i] eq 't') {
if ($genome[$i+1] eq 'a') { ++$ta; }
elsif ($genome[$i+1] eq 'g') { ++$tg; }
elsif ($genome[$i+1] eq 'c') { ++$ga; }
elsif ($genome[$i+1] eq 't') { ++$tt; }
etc.
Of course, the hash is a better solution for this problem, but I thought that the redundant testing problem should be pointed out.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|