comment on

I have a situation where I need to try multiple things and if any of them succeed I want to stop. However, I also need to do something if none of them succeed. I am currently using a very ugly construct kind of like this:

my $success = 0;

foreach my $try (@options) {
    if (exists $hash{$try}) {
        do_something($try);
        $success = 1;
        last;
    }
}

if (!$success) {
    log_failure();
}
[download]

Can anyone suggest a nicer way to do this? I particularly dislike the use of the $success flag. In my real code, I have many conditions to check and have to put the flag setting code and the "last" statement after each one, which feels redundant.

In reply to improve ugly flow control by perrin

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


Perl Monk, Perl Meditation
	PerlMonks